UCSBDiningMenuItemsController.java

1
package edu.ucsb.cs156.dining.controllers;
2
3
import edu.ucsb.cs156.dining.entities.MenuItem;
4
import edu.ucsb.cs156.dining.errors.EntityNotFoundException;
5
import edu.ucsb.cs156.dining.models.Entree;
6
import edu.ucsb.cs156.dining.models.MenuItemSearchResult;
7
import edu.ucsb.cs156.dining.repositories.MenuItemRepository;
8
import edu.ucsb.cs156.dining.services.UCSBDiningMenuItemsService;
9
import edu.ucsb.cs156.dining.statuses.ModerationStatus;
10
import io.swagger.v3.oas.annotations.Operation;
11
import io.swagger.v3.oas.annotations.Parameter;
12
import io.swagger.v3.oas.annotations.tags.Tag;
13
import java.util.List;
14
import java.util.Optional;
15
import lombok.extern.slf4j.Slf4j;
16
import org.springframework.beans.factory.annotation.Autowired;
17
import org.springframework.http.ResponseEntity;
18
import org.springframework.web.bind.annotation.GetMapping;
19
import org.springframework.web.bind.annotation.PathVariable;
20
import org.springframework.web.bind.annotation.RequestMapping;
21
import org.springframework.web.bind.annotation.RequestParam;
22
import org.springframework.web.bind.annotation.RestController;
23
24
@Tag(name = "UCSBDiningMenuItems")
25
@RestController
26
@RequestMapping("/api/diningcommons")
27
@Slf4j
28
public class UCSBDiningMenuItemsController extends ApiController {
29
30
  @Autowired UCSBDiningMenuItemsService ucsbDiningMenuItemsService;
31
32
  @Autowired MenuItemRepository menuItemRepository;
33
34
  @Operation(summary = "Search saved menu items by name")
35
  @GetMapping(value = "/menuitems/search", produces = "application/json")
36
  public ResponseEntity<List<MenuItemSearchResult>> search_menu_items(
37
      @Parameter(description = "At least two characters from the menu item name")
38
          @RequestParam(required = false)
39
          String q) {
40 3 1. search_menu_items : negated conditional → KILLED
2. search_menu_items : changed conditional boundary → KILLED
3. search_menu_items : negated conditional → KILLED
    if (q == null || q.trim().length() < 2) {
41 1 1. search_menu_items : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED
      return ResponseEntity.ok(List.of());
42
    }
43
44
    List<MenuItemSearchResult> results =
45
        menuItemRepository.findTop20ByNameContainingIgnoreCaseOrderByNameAscIdAsc(q.trim()).stream()
46
            .map(
47
                item ->
48 1 1. lambda$search_menu_items$0 : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::lambda$search_menu_items$0 → KILLED
                    new MenuItemSearchResult(
49
                        item.getId(),
50
                        item.getName(),
51
                        item.getDiningCommonsCode(),
52
                        item.getMealCode(),
53
                        item.getStation()))
54
            .toList();
55 1 1. search_menu_items : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED
    return ResponseEntity.ok(results);
56
  }
57
58
  @Operation(summary = "Get list of entrees being served at given meal, dining common, and day")
59
  @GetMapping(
60
      value = "/{date-time}/{dining-commons-code}/{meal-code}",
61
      produces = "application/json")
62
  public ResponseEntity<List<MenuItem>> get_menu_items(
63
      @Parameter(
64
              description =
65
                  "date (in iso format, e.g. YYYY-mm-dd) or date-time (in iso format e.g. YYYY-mm-ddTHH:MM:SS)")
66
          @PathVariable("date-time")
67
          String datetime,
68
      @PathVariable("dining-commons-code") String diningCommonsCode,
69
      @PathVariable("meal-code") String mealCode)
70
      throws Exception {
71
72
    List<Entree> body = ucsbDiningMenuItemsService.get(datetime, diningCommonsCode, mealCode);
73
74
    List<MenuItem> menuItems =
75
        ucsbDiningMenuItemsService.getOrCreateMenuItems(diningCommonsCode, mealCode, body);
76
77 1 1. get_menu_items : removed call to java/util/List::forEach → KILLED
    menuItems.forEach(
78
        (item) -> {
79 1 1. lambda$get_menu_items$0 : removed call to edu/ucsb/cs156/dining/entities/MenuItem::setReviews → KILLED
          item.setReviews(
80
              item.getReviews().stream()
81 2 1. lambda$get_menu_items$1 : replaced boolean return with true for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::lambda$get_menu_items$1 → KILLED
2. lambda$get_menu_items$1 : negated conditional → KILLED
                  .filter((review) -> review.getStatus() == ModerationStatus.APPROVED)
82
                  .toList());
83
        });
84 1 1. get_menu_items : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_items → KILLED
    return ResponseEntity.ok().body(menuItems);
85
  }
86
87
  @Operation(summary = "Get a single menu item by ID")
88
  @GetMapping(value = "/menuitem", produces = "application/json")
89
  public ResponseEntity<MenuItem> get_menu_item_by_id(
90
      @Parameter(description = "ID of the menu item") @RequestParam long id) throws Exception {
91
    Optional<MenuItem> menuItem = menuItemRepository.findById(id);
92 1 1. get_menu_item_by_id : negated conditional → KILLED
    if (menuItem.isEmpty()) {
93
      throw new EntityNotFoundException(MenuItem.class, id);
94
    }
95 1 1. get_menu_item_by_id : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_item_by_id → KILLED
    return ResponseEntity.ok().body(menuItem.get());
96
  }
97
}

Mutations

40

1.1
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_returns_empty_list_when_query_is_missing()]
negated conditional → KILLED

2.2
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_accepts_two_character_query()]
changed conditional boundary → KILLED

3.3
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_accepts_two_character_query()]
negated conditional → KILLED

41

1.1
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_returns_empty_list_when_query_is_missing()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED

48

1.1
Location : lambda$search_menu_items$0
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_accepts_two_character_query()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::lambda$search_menu_items$0 → KILLED

55

1.1
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_returns_empty_list_for_no_matches()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED

77

1.1
Location : get_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
removed call to java/util/List::forEach → KILLED

79

1.1
Location : lambda$get_menu_items$0
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
removed call to edu/ucsb/cs156/dining/entities/MenuItem::setReviews → KILLED

81

1.1
Location : lambda$get_menu_items$1
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
replaced boolean return with true for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::lambda$get_menu_items$1 → KILLED

2.2
Location : lambda$get_menu_items$1
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
negated conditional → KILLED

84

1.1
Location : get_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_items → KILLED

92

1.1
Location : get_menu_item_by_id
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:get_menu_item_by_id_not_found()]
negated conditional → KILLED

95

1.1
Location : get_menu_item_by_id
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:get_menu_item_by_id_success()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_item_by_id → KILLED

Active mutators

Tests examined


Report generated by PIT 1.22.1