UCSBDiningMenuItemsController.java

1
package edu.ucsb.cs156.dining.controllers;
2
3
import edu.ucsb.cs156.dining.entities.MenuItem;
4
import edu.ucsb.cs156.dining.errors.EntityNotFoundException;
5
import edu.ucsb.cs156.dining.models.Entree;
6
import edu.ucsb.cs156.dining.models.MenuItemSearchResult;
7
import edu.ucsb.cs156.dining.models.MenuItemSummary;
8
import edu.ucsb.cs156.dining.repositories.MenuItemRepository;
9
import edu.ucsb.cs156.dining.services.UCSBDiningMenuItemsService;
10
import edu.ucsb.cs156.dining.statuses.ModerationStatus;
11
import io.swagger.v3.oas.annotations.Operation;
12
import io.swagger.v3.oas.annotations.Parameter;
13
import io.swagger.v3.oas.annotations.tags.Tag;
14
import java.util.List;
15
import java.util.Optional;
16
import lombok.extern.slf4j.Slf4j;
17
import org.springframework.beans.factory.annotation.Autowired;
18
import org.springframework.http.ResponseEntity;
19
import org.springframework.web.bind.annotation.GetMapping;
20
import org.springframework.web.bind.annotation.PathVariable;
21
import org.springframework.web.bind.annotation.RequestMapping;
22
import org.springframework.web.bind.annotation.RequestParam;
23
import org.springframework.web.bind.annotation.RestController;
24
25
@Tag(name = "UCSBDiningMenuItems")
26
@RestController
27
@RequestMapping("/api/diningcommons")
28
@Slf4j
29
public class UCSBDiningMenuItemsController extends ApiController {
30
31
  @Autowired UCSBDiningMenuItemsService ucsbDiningMenuItemsService;
32
33
  @Autowired MenuItemRepository menuItemRepository;
34
35
  @Operation(summary = "Get list of entrees being served at given meal, dining common, and day")
36
  @GetMapping(
37
      value = "/{date-time}/{dining-commons-code}/{meal-code}",
38
      produces = "application/json")
39
  public ResponseEntity<List<MenuItem>> get_menu_items(
40
      @Parameter(
41
              description =
42
                  "date (in iso format, e.g. YYYY-mm-dd) or date-time (in iso format e.g. YYYY-mm-ddTHH:MM:SS)")
43
          @PathVariable("date-time")
44
          String datetime,
45
      @PathVariable("dining-commons-code") String diningCommonsCode,
46
      @PathVariable("meal-code") String mealCode)
47
      throws Exception {
48
49
    List<Entree> body = ucsbDiningMenuItemsService.get(datetime, diningCommonsCode, mealCode);
50
51
    List<MenuItem> menuItems =
52
        ucsbDiningMenuItemsService.getOrCreateMenuItems(diningCommonsCode, mealCode, body);
53
54 1 1. get_menu_items : removed call to java/util/List::forEach → KILLED
    menuItems.forEach(
55
        (item) -> {
56 1 1. lambda$get_menu_items$0 : removed call to edu/ucsb/cs156/dining/entities/MenuItem::setReviews → KILLED
          item.setReviews(
57
              item.getReviews().stream()
58 2 1. lambda$get_menu_items$1 : replaced boolean return with true for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::lambda$get_menu_items$1 → KILLED
2. lambda$get_menu_items$1 : negated conditional → KILLED
                  .filter((review) -> review.getStatus() == ModerationStatus.APPROVED)
59
                  .toList());
60
        });
61 1 1. get_menu_items : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_items → KILLED
    return ResponseEntity.ok().body(menuItems);
62
  }
63
64
  @Operation(
65
      summary = "Get a single menu item by ID",
66
      description =
67
          "Returns the id, name, dining commons code, meal code and station of the menu item."
68
              + " Reviews are not included.")
69
  @GetMapping(value = "/menuitem", produces = "application/json")
70
  public ResponseEntity<MenuItemSummary> get_menu_item_by_id(
71
      @Parameter(description = "ID of the menu item") @RequestParam long id) throws Exception {
72
    Optional<MenuItem> menuItem = menuItemRepository.findById(id);
73 1 1. get_menu_item_by_id : negated conditional → KILLED
    if (menuItem.isEmpty()) {
74
      throw new EntityNotFoundException(MenuItem.class, id);
75
    }
76 1 1. get_menu_item_by_id : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_item_by_id → KILLED
    return ResponseEntity.ok().body(new MenuItemSummary(menuItem.get()));
77
  }
78
79
  @Operation(
80
      summary = "Search menu items by name (case-insensitive, returns at most 20 results)",
81
      description =
82
          "Returns the id, name and dining commons code of menu items whose name contains the"
83
              + " query. A blank query returns an empty list.")
84
  @GetMapping(value = "/menuitem/search", produces = "application/json")
85
  public ResponseEntity<List<MenuItemSearchResult>> search_menu_items(
86
      @Parameter(description = "Text to look for in the menu item name") @RequestParam
87
          String query) {
88 1 1. search_menu_items : negated conditional → KILLED
    if (query.isBlank()) {
89 1 1. search_menu_items : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED
      return ResponseEntity.ok().body(List.of());
90
    }
91
    List<MenuItemSearchResult> results =
92
        menuItemRepository.findTop20ByNameContainingIgnoreCaseOrderByNameAscIdAsc(query).stream()
93
            .map(MenuItemSearchResult::new)
94
            .toList();
95 1 1. search_menu_items : replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED
    return ResponseEntity.ok().body(results);
96
  }
97
}

Mutations

54

1.1
Location : get_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
removed call to java/util/List::forEach → KILLED

56

1.1
Location : lambda$get_menu_items$0
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
removed call to edu/ucsb/cs156/dining/entities/MenuItem::setReviews → KILLED

58

1.1
Location : lambda$get_menu_items$1
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
replaced boolean return with true for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::lambda$get_menu_items$1 → KILLED

2.2
Location : lambda$get_menu_items$1
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
negated conditional → KILLED

61

1.1
Location : get_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:approved_reviews_only_are_included_in_menu_items_response()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_items → KILLED

73

1.1
Location : get_menu_item_by_id
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:get_menu_item_by_id_not_found()]
negated conditional → KILLED

76

1.1
Location : get_menu_item_by_id
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:get_menu_item_by_id_success()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::get_menu_item_by_id → KILLED

88

1.1
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_returns_empty_list_for_empty_query_without_searching()]
negated conditional → KILLED

89

1.1
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_returns_empty_list_for_empty_query_without_searching()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED

95

1.1
Location : search_menu_items
Killed by : edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests.[engine:junit-jupiter]/[class:edu.ucsb.cs156.dining.controllers.UCSBDiningMenuItemsControllerTests]/[method:search_menu_items_returns_empty_list_when_nothing_matches()]
replaced return value with null for edu/ucsb/cs156/dining/controllers/UCSBDiningMenuItemsController::search_menu_items → KILLED

Active mutators

Tests examined


Report generated by PIT 1.22.1